tigor/QBitRun
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

[wip] error-action: added missing case for empty string

Browse source
This commit is contained in:
Tigor Hutasuhut 2024-06-25 16:53:41 +07:00
parent b21b352923
commit f0feb88d5a
2 changed files with 11 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
lib/workflow/job.go
View file

@ -30,7 +30,7 @@ func (ea *ErrorAction) UnmarshalYAML(value *yaml.Node) error {
switch lowered { switch lowered {
case "continue": case "continue":
*ea = ErrorActionContinue *ea = ErrorActionContinue
case "stop-job": case "", "stop-job":
*ea = ErrorActionStopJob *ea = ErrorActionStopJob
case "stop-action": case "stop-action":
*ea = ErrorActionStopAction *ea = ErrorActionStopAction

10
lib/workflow/job_test.go
View file

@ -38,6 +38,16 @@ func TestErrorAction_UnmarshalYAML(t *testing.T) {
input: []byte(`E: `), input: []byte(`E: `),
want: ErrorActionStopJob, want: ErrorActionStopJob,
}, },
{
name: "whitespace only is stop-job",
input: []byte(`E: " "`),
want: ErrorActionStopJob,
},
{
name: "empty is stop-job",
input: []byte(`E: ""`),
want: ErrorActionStopJob,
},
{ {
name: "unset is stop-job 2", name: "unset is stop-job 2",
input: []byte(`foo: bar`), input: []byte(`foo: bar`),